-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation inside decompiled files #116
Comments
I am able to navigate through decompiled files, is this still an issue ? or was it just fixed lately ? |
I tested this yesterday when I opened the issue🤔 do you have a screen recording of you doing this? I am able to navigate to a decompiled file, but I can't continue navigating |
Can confirm this works fine for me too, same behaviour as vscode, gd works fine inside decompiled files even to other decompiled files. I can record something in a test project when i can. |
can confirm it works for me too (and has worked for quite a while for me) |
Super weird |
yes, I have the same issue. It can't go to other definition of the decompiled file. |
I'm pretty new to neovim over all. But I've been able to get it to work sometimes. This commit is my config ive been using where its sometimes working.
The language server files im using came from The key map im using to navigate tot eh definition is this At first today i tried setting here is a video of when i got it working. Closing and opening neovim caused it to stop working. here is what happens when its not working. I'm very new to neovim, I only started using it as a new years resolution as a pivot from IdeaVim. So its very possible I made a mistake when making my config. Im not sure what I did to get it working in the first place and im not really sure what to change to try and force these decompiled temp file buffers to attach to the lsp(if this is even the issue). I'm going to keep messing around to find a solution, I was screen recording during making this work but its a lot of video to look through. If there is any more information i can give to make solving this easier let me know |
I figured it out and it might explain why it works for some and not others. For some reason the initial auto targeting of the solution seems to break going to definitions. My guess some people always set the target without relying on the auto targeting.
Issue:
Workaround:
here is a video of the workaround working |
that's very weird; i'm not using lock target / CSTarget and yet navigation still works for me in decompiled files |
Hmm, I tried to do the same things as you did and I am still not able to navigate in decompiled code like that🤔 |
Okay I just tried on my windows VM, and there it seems to work. However, it does not work on macOS for me |
Related to navigation in decompiled files, when I try to navigate to defintion of a type that is in a different project it will also navigate to the decompiled version of that type. Is this a limitation of the LSP itself? Related to this seems that the LSP intellisense uses a the decompiled version to provide intellisense for a type from the referenced project, adding a field for example, I have to recompile the referenced project and restart the language server in order for the diagnostics and autocomplete to pick this up thse changes in the referenced project. All of the projects are part of a single solution. |
I see that vscode now has support for navigation inside a decompiled file. This is not the case for this plugin. It only has some very simple hover information on some things.
I want to be able to keep navigating in the decompiled files.
Currently, we are falling back to the currently attached solution, and I think that was the case for vscode previously, but it seems they must have changed something to make it better
The text was updated successfully, but these errors were encountered: