Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger issue with plugin-slack-catalog-backend #71

Closed
AndreaBacquele opened this issue Oct 7, 2024 · 5 comments · Fixed by #72
Closed

Logger issue with plugin-slack-catalog-backend #71

AndreaBacquele opened this issue Oct 7, 2024 · 5 comments · Fixed by #72

Comments

@AndreaBacquele
Copy link

Hi! ✋
We are using your plugin-slack-catalog-backend
We have a type error when we use fromConfig()in our backend module.
With Backstage config in our createBackendModule, we use logger: coreServices.logger,.
But we have this type error: Argument of type 'LoggerService' is not assignable to parameter of type 'Logger'.

Would you happen to have a solution? We need to update our Backstage version to the 1.31 and they start to deprecate loggerToWinstonLogger method.

Thanks in advance

@bbckr bbckr linked a pull request Oct 7, 2024 that will close this issue
@bbckr
Copy link
Contributor

bbckr commented Oct 7, 2024

Thanks for raising @AndreaBacquele. Opening a PR and will have the team review it once they are online.

@AndreaBacquele
Copy link
Author

AndreaBacquele commented Oct 7, 2024

Thank you @bbckr 🤩

@bbckr bbckr closed this as completed in #72 Oct 7, 2024
@bbckr
Copy link
Contributor

bbckr commented Oct 7, 2024

Leaving reopened until the package is published, will be version 2.0.0

@bbckr bbckr reopened this Oct 7, 2024
@AndreaBacquele
Copy link
Author

Just to keep my team updated: Do you have an idea when the package will be published? :)

@bbckr
Copy link
Contributor

bbckr commented Oct 8, 2024

Just to keep my team updated: Do you have an idea when the package will be published? :)

This was published yesterday https://github.com/seatgeek/backstage-plugins/releases/tag/%40seatgeek%2Fbackstage-plugin-slack-catalog-backend%402.0.0

@bbckr bbckr closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants