Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more comprehensive unit tests #17

Open
seanohue opened this issue Oct 14, 2022 · 3 comments
Open

more comprehensive unit tests #17

seanohue opened this issue Oct 14, 2022 · 3 comments
Assignees
@billy-le
Labels
enhancement New feature or request hacktoberfest

Comments

@seanohue
Copy link
Owner

Given that there are a few bugs in the issues, I think more comprehensive unit testing would help. This is kind of a broad scope, but anything that is demonstrated in the README should be unit tested and proven to work as described.
@seanohue seanohue added enhancement New feature or request hacktoberfest labels Oct 14, 2022
@billy-le
Copy link
Contributor

Hello, :) I would love to give this a try

@seanohue
Copy link
Owner Author

@billy-le Thanks! I've assigned this to you, feel free to submit a PR adding some unit tests

@billy-le billy-le mentioned this issue Oct 14, 2022
Merged
@billy-le
Copy link
Contributor

Added a few test suites for now until I can continue working on it again. Would love your feedback if you want me to change anything.

@billy-le billy-le mentioned this issue Oct 15, 2022
Merged
seanohue pushed a commit that referenced this issue Oct 22, 2022
@billy-le
improve-unit-tests/#17 - part 2 (#23)
3f3dbef 
* improve-unit-tests: added test suite for validate.js. added validateParameters to validate shape of inputs

* improve-unit-tests: added additional tests for all methods of TimeCrunch

* improve-unit-tests: prettified file

* improve-unit-tests: fixed error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billy-le billy-le

Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanohue @billy-le