Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow " in URIs #87

Closed
nox opened this issue Mar 15, 2021 · 3 comments
Closed

Allow " in URIs #87

nox opened this issue Mar 15, 2021 · 3 comments

Comments

@nox
Copy link
Contributor

nox commented Mar 15, 2021

There are user-agents out there sending " without percent-encoding it in the URI, it would be nice if Hyper would allow those. The character was drive-by disallowed in #40. I can patch the non-optimised code but I'll need some hand-holding to patch the SIMD paths, as #41 still holds.

@nox
Copy link
Contributor Author

nox commented Mar 15, 2021

An example of request received in the wild, AFAIK this was a request generated by GeForce Experience:

GET /nvidia_web_services/controller.gfeclientcontent.php/com.nvidia.services.GFEClientContent.getShieldReady/{"gcV":"2.2.2.0","dID":"1341","osC":"6.20","is6":"1","lg":"1033","GFPV":"389.08","isO":"1","sM":"16777216"} HTTP/1.0
Host: gfwsl.geforce.com

Note the JSON embedded directly in the URI path.

@seanmonstar
Copy link
Owner

I can't say I know why it was disallowed in that PR, but I'm fine with it being fixed. I imagine we can ask in Discord around how to update the SIMD stuff. With a sufficiently long example in the tests (perhaps just the one you pasted), CI should be able to catch it I assume.

@nox
Copy link
Contributor Author

nox commented Mar 16, 2021

I found someone to help me at Cloudflare, here is my branch. I am a little bit worried that the test I made from the GFE request isn't failing locally, though AFAIK it should be taking the SIMD path given how long the URI is.

nox added a commit to nox/httparse that referenced this issue Mar 16, 2021
nox added a commit to nox/httparse that referenced this issue Mar 16, 2021
BenxiangGe pushed a commit to BenxiangGe/httparse that referenced this issue Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants