-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow " in URIs #87
Comments
An example of request received in the wild, AFAIK this was a request generated by GeForce Experience:
Note the JSON embedded directly in the URI path. |
I can't say I know why it was disallowed in that PR, but I'm fine with it being fixed. I imagine we can ask in Discord around how to update the SIMD stuff. With a sufficiently long example in the tests (perhaps just the one you pasted), CI should be able to catch it I assume. |
I found someone to help me at Cloudflare, here is my branch. I am a little bit worried that the test I made from the GFE request isn't failing locally, though AFAIK it should be taking the SIMD path given how long the URI is. |
There are user-agents out there sending
"
without percent-encoding it in the URI, it would be nice if Hyper would allow those. The character was drive-by disallowed in #40. I can patch the non-optimised code but I'll need some hand-holding to patch the SIMD paths, as #41 still holds.The text was updated successfully, but these errors were encountered: