-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fan lights not detected #15
Comments
For now you can try installing my fork where i reverted recent changes (adding occupancy sensors and light checks) that broke things for me. |
Sounds good, thanks a bunch for the reply. I am occupied this week, but hopefully next week I'll learn how to install from a branch, instead of using npm, and report back.
Shash
… On Mar 14, 2017, at 10:17 AM, pponce ***@***.***> wrote:
For now you can try installing my fork where i reverted recent changes (adding occupancy sensors and light checks) that broke things for me.
pponce/homebridge-bigAssFans
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Here you go: |
Thanks a bunch! That worked like a charm, lights are now detected and controllable via the Home App.
Thanks again!
Shash
…-----Original Message-----
From: pponce <[email protected]>
To: sean9keenan/homebridge-bigAssFans <[email protected]>
Cc: shashchatter <[email protected]>; Author <[email protected]>
Sent: Tue, Mar 14, 2017 6:29 pm
Subject: Re: [sean9keenan/homebridge-bigAssFans] Fan lights not detected (#15)
Here you go:
npm install -g pponce/homebridge-bigAssFans
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Hey @pponce - what's the error that you're getting? and what type of model fan do you have? If people are seeing issues I do want to fix it 😅 |
Specifically - do you know if it's an issue in the homebridge-bigAssFans repo or the bigassfanAPI? Or what exact revert allowed you to fix it. From the logs it's not exactly clear to me what might have caused the issue, and I saw that you reverted both of those repos in trying to fix this issue @pponce |
I'm not really sure. I reverted back to before the recent changes that were pushed 16 days ago. The only recent change I kept was the "hack" to fix the home-bridge crashing issue with the call back being called twice. The light issue happened after this commit reference in this comment: Also the occupancy detection does not seem to work. Always seems to show occupancy detected for me regardless of actual occupancy. But that looks to be a known open issue #3 I'll test things by pointing to your current bigassfanAPI and see if I only really needed to revert homebridge-bigassfans. |
Ok Also i was not getting an error per say. I was getting an incorrect "no light" message for each fan. Oh and I have two haiku senseme fans. They were early models. When they just came out. The official app calls them "Haiku with SenseMe". Not sure how i can get the exact model number for you. |
My current guess is that this line in bigassfansAPI is not setting the property value correctly. this.light.createGetField('exists', ['DEVICE', 'LIGHT'], false, undefined, "PRESENT"); // Unknown false string.. WAY too lazy to unplug from fan |
I reset my fork to match your current master. [3/19/2017, 10:56:15 AM] [Big Ass Fan] this.myBigAss.light.exists= undefined, Found a light for: Haiku Fan Light |
I'm experiencing a weird issue with the light. I can turn on/off the light within the home app. However if I use the wall control to turn on the light or fan, the home app does not recognize the light or fan as being on. edit: using pponce's branch the light and fan does show on/off if I use the wall control however it only seems to report correctly if the home app is forced closed and open. It does not update the on/off status in real time for some reason. |
@pponce - first off, I'm sorry that I've been so MIA on this repo, the info and debugging you did is really great and useful. Regarding the line below:
I'm betting you're right, that this is the issue. If you're interested I can help you understand / get the info needed to help get this working + change it yourself if you're so inclined. In particular what I'm going to suggest is changing the line in the BigAssAPI to turn logging on. Once you do this if you run any of the examples you'll see a barrage of all of the messages that are coming off of the fan I ran this:
Afterwards I see the output:
That's the raw message from the fan itself - it's likely that you see a different message somewhere in there that has LIGHT and some identifier that the light exists. Either way this line is what the Given this I see two solutions for the library as a whole:
Again sorry for me being MIA and leaving this broken all the while :/ @djfatal - I believe this is because the fan no longer broadcasts it's updates as a multicast UDP packet, and instead only sends this to the person requesting the update. This is an unfortunate change because this means that we'll have to constantly be polling the fan for updates. This isn't a terribly involved change, but it's definitely non-trivial, and probably should be implemented as a feature / option inside of BigAssFansAPI instead of inside of the homebridge plugin. I probably don't have the bandwidth to do this anytime soon, but I'd be more than welcome to accept any PR's. For anyone interested just let me know if you start so I don't accidentally start it before you get it back to me 👍 |
@sean9keenan No problem on any delay here. I was able to just bypass the check in the mean time to get things to work. So the plot thickens: have a look at my fork. i made the changes to turn on logging and added your comments suggested console.log messages. Links to the changes: Here is the output. for some reasons "and lightExists: 'true'" when i turn on logging and i made the small changes. |
Awesome, thanks! Hmm, I see that lightExists: 'true' gets printed, but I don't see
get printed from this line. You said that the light is working properly though? O.o I'm a bit confused as to why this would be the case :| |
@sean9keenan my bad. i accidently deleted this key line that kickstarts most of the logic in the code. :) [4/1/2017, 6:39:50 PM] [Big Ass Fan] Initializing BigAssFans platform... and lightExists: 'true' server got: (KidsHaiku;SMARTSLEEP;MAXSPEED;6) from 192.168.1.202:31415 and lightExists: 'true' server got: (Haiku;DEVICE;BEEPER;ON) from 192.168.1.145:31415 |
@sean9keenan The author maintains homebridge-hue and it's rock solid. Sounds like it might help here. |
@sean9keenan I created a fix that works. At least for me and i think should work generally. Can you let me know if this is an acceptable approach. If you think this is an acceptable solution for this issue, i submitted a PR. |
I've been running my fix for a couple weeks now with no issues with detecting lights. The only issue i have remaining now is that the occupancy sensors always show triggered in the home app. |
Awesome, I am going to try it out now. I hope the occupancy sensor can work in the future. :) |
installed this version last night. working great thus far. thanks @pponce |
+1 working |
@sean9keenan Just checking in. PR look good? |
This has been workin great for me thus far. Does anyone know if the BigAssFan API support Haiku Lights too? I have those as well and this current plugin doesn't detect them. |
No problem. Was fun to learn a bit and figure this out. |
I'm glad it was fun and that you learned something!
That library does look quite interesting. We might also need to do a bit
more sleuthing to confirm that it actually requires polling, or if you need
to just fall back to polling in the case your network is blocking broadcast
UDP traffic.
…On Tue, May 23, 2017 at 8:45 AM, pponce ***@***.***> wrote:
No problem. Was fun to learn a bit and figure this out.
Have you taken a look at this project by ebaauw?
https://github.com/ebaauw/homebridge-lib
He's implemented a polling feature that might come in handy for updating
bigAssFans to poll since you mentioned bigAssFans changed the way the fans
communicate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACAn3LhAPtVk3-QSLcl3YnI0gkVvDazCks5r8v8agaJpZM4Maj1h>
.
|
Any progress with the occupancy sensor? :) |
Or could we use this as a model for setting up a longpoll for each fan? https://github.com/tekuonline/homebridge-assurelink2/blob/master/index.js
|
For some reason the light stopped working again. edit: n/m got it working again after I uninstalled and reinstalled the homebridge. |
Is any progress still being made on this? |
For some reason I started experiencing "No lights exists" again. I am trying the fork from @pponce and it is having this problem too. edit: looks like my setup got corrupted somehow. I got things working again once I setup on a different raspberry pi. |
I have two Haiku fans, both with fan lights, and lights are detected and controllable by either the iPhone app or the wall controller. I have recently updated the homebridge plugins with npm (npm upgrade; npm update -g), and feel dumb to not have recorded the prior versions of node.js, or homebridge, or the plugins! Prior to the update, homebridge used to detect.control lights on the fans just fine. Now, the lights are not detected, please see the tail end of the log at http://pastebin.com/4BrKDq4k.
Fan FW: v2.2.41
Wall Controller: v2.2.43
Node.js version 7.7.2
homebridge version: 0.4.16
/usr/lib
\u251c\u2500\u2500 [email protected]
\u251c\u2500\u2500 [email protected]
\u251c\u2500\u2500 [email protected]
\u251c\u2500\u2500 [email protected]
\u251c\u2500\u2500 [email protected]
\u2514\u2500\u2500 [email protected]
Node running on Ubuntu:
Distributor ID: Ubuntu
Description: Ubuntu 16.04.2 LTS
Release: 16.04
Codename: xenial
Linux chattersrv 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
The text was updated successfully, but these errors were encountered: