Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SERIAL_AUTO_CR inconsistently implemented #48

Open
bennoleslie opened this issue Sep 26, 2020 · 1 comment
Open

SERIAL_AUTO_CR inconsistently implemented #48

bennoleslie opened this issue Sep 26, 2020 · 1 comment

Comments

@bennoleslie
Copy link

In some implementation (rockpro64) the CR is sent after the LF, while in others (such as imx) it is sent prior to the LF.

I think it should be sent prior (as in, imx is correct). Is there a reason the rockpro64 is implemented differently?
@axel-h
Copy link
Member

axel-h commented Sep 27, 2020 •
edited
Loading

yes this is a copy&paste bug that keeps spreading. I've already upstreamed a few patches that fix this for the platform I have access to.

See also #38 (comment)

This was referenced Dec 29, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bennoleslie @axel-h