Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(fill_db_data): Remove 30s sleep of waiting for schema agreement #9792

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roydahan
Copy link
Contributor

@roydahan roydahan commented Jan 13, 2025

Now that all of our recent releases contains raft with consistent scehma management, this sleep isn't needed anymore.

Test: rolling upgrades.

Fixes: #9660

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@fruch
Copy link
Contributor

fruch commented Jan 15, 2025

@roydahan seems test was failing cause it was missing the extra timeout for the truncate operation.

maybe for the safe side, rebase this PR, and try it again ?

…eement

Now that all of our recent releases contains raft with consistent scehma
management, this sleep isn't needed anymore.

Test: rolling upgrades.

Fixes: scylladb#9660
@roydahan roydahan force-pushed the remove-schema-sleep branch from 8975202 to 82b5ae2 Compare January 20, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sleep for schema agreement - since we now have raft with consistent schema management
2 participants