From 011fb2ce1e9baa2322488ed53687dc79815344c8 Mon Sep 17 00:00:00 2001 From: Vlad Zolotarov Date: Fri, 10 May 2024 15:48:43 -0400 Subject: [PATCH] scylla-node/Debian_install.yml: Don't check if the installed scylla version appears in the repo exactly once unless we are upgrading We have a check that validates that a value in `scylla_version` matches exactly one (full) scylla verison from the repository so that the Role can install it. However this check is only relevant when we are going to install anything, and when scylla is already installed and we are not upgrading - we are not going to. Hence, this check is only making noise in such a case. One common example of such a situation is when a custom build is installed. Signed-off-by: Vlad Zolotarov --- ansible-scylla-node/tasks/Debian_install.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ansible-scylla-node/tasks/Debian_install.yml b/ansible-scylla-node/tasks/Debian_install.yml index c7e510f5..ab389f26 100644 --- a/ansible-scylla-node/tasks/Debian_install.yml +++ b/ansible-scylla-node/tasks/Debian_install.yml @@ -19,7 +19,7 @@ - name: "Validate scylla version correctness" ansible.builtin.fail: msg: "Too many/few choices for a requested version '{{ scylla_version_to_install }}': {{ aptversions.stdout_lines }}. Bailing out!" - when: aptversions.stdout_lines | length != 1 + when: (not scylla_is_installed or upgrade_version) and aptversions.stdout_lines | length != 1 - name: If Scylla is installed check if it's the same version as requested fail: