Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between released version and tags #428

Closed
Bouncheck opened this issue Jan 28, 2025 · 5 comments
Closed

Discrepancy between released version and tags #428

Bouncheck opened this issue Jan 28, 2025 · 5 comments

Comments

@Bouncheck
Copy link
Collaborator

According to the logs of github actions, the most recent changes should be included in the newest (3.11.5.5):
https://github.com/scylladb/java-driver/actions/runs/12991005588/job/36227506405
For example commit f70ec36 should be there.
However when looking at version tag the recent commit history seems to be incomplete:
https://github.com/scylladb/java-driver/commits/3.11.5.5/

@dkropachev
Copy link
Collaborator

Yeah, it is because release process is broken due to the branch restriction, we need to find a way to allow github action push changes to master

@dkropachev
Copy link
Collaborator

Discrepancy is fixed by 4b1cd4c and e653080

@dkropachev
Copy link
Collaborator

Ok, I have removed this restriction, next time it will work just fine.

@Bouncheck
Copy link
Collaborator Author

Discrepancy is fixed by 4b1cd4c and e653080

That's the other half of the problem, specifically that the auto generated commits with version changes cannot be pushed automatically and that those were not on scylla-3.x.

The example I described here is that when you go to tag 3.11.5.5 it does not have:
Make git ignore directories that are left after 4.x
TokenAwarePolicy: fix bad perf of ReplicaOrdering.RANDOM

This makes it functionally different from released 3.11.5.5. Some tools may depend on repo tags being accurate, like for example scylla-java-driver-matrix.

@dkropachev
Copy link
Collaborator

Discrepancy is fixed by 4b1cd4c and e653080

That's the other half of the problem, specifically that the auto generated commits with version changes cannot be pushed automatically and that those were not on scylla-3.x.

The example I described here is that when you go to tag 3.11.5.5 it does not have: Make git ignore directories that are left after 4.x TokenAwarePolicy: fix bad perf of ReplicaOrdering.RANDOM

This makes it functionally different from released 3.11.5.5. Some tools may depend on repo tags being accurate, like for example scylla-java-driver-matrix.

Fixed, take a look : 3.11.5.4...3.11.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants