Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] UMAP results broken compared to scanpy #328

Closed
j-bac opened this issue Feb 17, 2025 · 2 comments
Closed

[BUG] UMAP results broken compared to scanpy #328

j-bac opened this issue Feb 17, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@j-bac
Copy link

j-bac commented Feb 17, 2025

Describe the bug
Given same UMAP and neighbors graph search parameters, UMAP results look quite different between rapids_singlecell UMAP:
Image

And scanpy.tl.umap:
Image

Steps/Code to reproduce bug
In general UMAPs seem more unstable on GPU and the visualization is often affected by few distant and isolated points. I am not sure whether the problem comes from different kNN search results or different UMAP implementation

Expected behavior
Similar UMAPs to scanpy implementation.

@j-bac j-bac added the bug Something isn't working label Feb 17, 2025
@Intron7
Copy link
Member

Intron7 commented Feb 17, 2025

Thanks for raising this! This is related to #196, where we discussed differences between cuML’s UMAP and umap-learn. Neither rapids-singlecell nor Scanpy directly implement the UMAP algorithm; both rely on these underlying libraries. Some differences are expected due to variations in initialization, optimization strategies, and parallelism in cuML.

If you believe this is an issue with cuML’s UMAP itself rather than its usage in rapids-singlecell, I’d recommend raising it directly with the cuML team at rapidsai/cuml. If there’s a specific issue affecting integration, feel free to provide a minimal reproducible example.

Closing this for now, but happy to reopen if there's something actionable on our end.

@Intron7 Intron7 closed this as completed Feb 17, 2025
@wphicks
Copy link

wphicks commented Feb 19, 2025

With rapidsai/raft#2568 merged, this may have been addressed in the cuML 25.04 nightly release. If not, please do let us know over at https://github.com/rapidsai/cuml/issues, and the RAPIDS team will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants