Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End round early to prevent wait times if people leave #343

Open
Bios-Marcel opened this issue Oct 19, 2024 · 0 comments
Open

End round early to prevent wait times if people leave #343

Bios-Marcel opened this issue Oct 19, 2024 · 0 comments
Labels
enhancement improvement of any kind good first issue Good for newcomers hacktoberfest Good first issue for hacktoberfest!
Milestone

Comments

@Bios-Marcel
Copy link
Member

Bios-Marcel commented Oct 19, 2024

There are two scenarios where we can end a round early.

  1. The drawer leaves before choosing a word.

Having to wait two minutes for nothing is kind of annoying. No player will be at a disadvantage if we end early here.

  1. If the last guessing player leaves

Similar to 1, but not as bad. Here we should be careful, that we don't necessarily count this as a negative for the drawing player. This should not reduce their overall points, as it would also not do so, if someone leaves as the second last person guessing.

Both the next-turn and game-over event should be extended with a field that indicates the round ended early due to the last guessers having disconnected. Something like earlyTurnEndDueToDisconnect.

This logic can be implemented on the tick side. There should be a sensible time-frame for allowing to reconnect.

@Bios-Marcel Bios-Marcel added the enhancement improvement of any kind label Oct 19, 2024
@Bios-Marcel Bios-Marcel added this to the 1.0.0 milestone Oct 19, 2024
@Bios-Marcel Bios-Marcel added good first issue Good for newcomers hacktoberfest Good first issue for hacktoberfest! labels Oct 20, 2024
@Bios-Marcel Bios-Marcel changed the title Round should end early a while after the last guessing player leaves End round early to prevent wait times if people leave Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement of any kind good first issue Good for newcomers hacktoberfest Good first issue for hacktoberfest!
Projects
None yet
Development

No branches or pull requests

2 participants
@Bios-Marcel and others