Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Words | Split English into US and GB #208

Closed
maquis196 opened this issue Feb 19, 2021 · 5 comments
Closed

Words | Split English into US and GB #208

maquis196 opened this issue Feb 19, 2021 · 5 comments
Labels
enhancement improvement of any kind
Milestone

Comments

@maquis196
Copy link
Contributor

So a group of us play this and often were caught out by US spellings, so wanted to mirror the current en dictionary, compare it to a GB dictionary and "fix" the difference.

maquis196 added a commit to maquis196/scribble.rs that referenced this issue Feb 19, 2021
@maquis196
Copy link
Contributor Author

I'm working on a small script to compare the en_us to '/usr/share/dict/british-english-large' so we can filter the difference for manual comparison (at this stage)

@Bios-Marcel
Copy link
Member

uhm, how about we make a dictionary that supports different writings?

maquis196 added a commit to maquis196/scribble.rs that referenced this issue Feb 19, 2021
@maquis196
Copy link
Contributor Author

uhm, how about we make a dictionary that supports different writings?

You mean have single "english" dictionary that supports multiple options for a specific word? So 'Norway' would be the same everywhere but say 'Shopping Cart' would also have 'Shopping Trolley' next to it and the app would know to use the gb option by default?

For now, would it be worth merging the eventual pr when its ready for this and then refactor the code to merge the two dictionaries into something smarter? (I ask because the sooner the above is live the better). For the end user, theyd still have English (US) or English (GB) to choose from. How is this problem handled in similar apps?

@Bios-Marcel Bios-Marcel added the enhancement improvement of any kind label Feb 20, 2021
@Bios-Marcel Bios-Marcel added this to the 1.0.0 milestone Feb 20, 2021
@Bios-Marcel
Copy link
Member

#213 I derived a new issue

@Bios-Marcel
Copy link
Member

Fixed with #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement of any kind
Projects
None yet
Development

No branches or pull requests

2 participants