Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear when namechange is comitted to the server #28

Open
Bios-Marcel opened this issue Mar 9, 2021 · 6 comments
Open

Unclear when namechange is comitted to the server #28

Bios-Marcel opened this issue Mar 9, 2021 · 6 comments

Comments

@Bios-Marcel
Copy link
Member

While there's an "Ok" button as soon as you enter the textfield, it seems like leaving the menu is what triggers the namechange. I am wondering whether this could be weird for the player. I'd say it'd be okay to send it to the server right away, it's not that much traffic. This way for example, a player could change his name and directly ask their friends what they think about the name. Now they'd ask and their friends would be confused saying "your name didn't" change.

@BigETI
Copy link
Member

BigETI commented Mar 19, 2021

So you are suggesting doing name changes while typing? That is absolutely possible.

@Bios-Marcel
Copy link
Member Author

Maybe not after every letter, but with a short delay or on lobby close if it hasn't already been comitted by delay?

@BigETI
Copy link
Member

BigETI commented Mar 19, 2021

I mean it worked fine when I tested it, you could see in real-time when someone was changing their name.

@Bios-Marcel
Copy link
Member Author

But it's unnecessary spamming, isn't it? I'd prefer to not do that.

@BigETI
Copy link
Member

BigETI commented Mar 19, 2021

You are showing that in chat, don't you? Then yeah this might be spammy. :D

@Bios-Marcel
Copy link
Member Author

Nah, I am not. I am talking about spamming network requests and causing constant update events on all clients.

But maybe displaying name changes in chat might not be a bad idea xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants