-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unclear when namechange is comitted to the server #28
Comments
So you are suggesting doing name changes while typing? That is absolutely possible. |
Maybe not after every letter, but with a short delay or on lobby close if it hasn't already been comitted by delay? |
I mean it worked fine when I tested it, you could see in real-time when someone was changing their name. |
But it's unnecessary spamming, isn't it? I'd prefer to not do that. |
You are showing that in chat, don't you? Then yeah this might be spammy. :D |
Nah, I am not. I am talking about spamming network requests and causing constant update events on all clients. But maybe displaying name changes in chat might not be a bad idea xD |
While there's an "Ok" button as soon as you enter the textfield, it seems like leaving the menu is what triggers the namechange. I am wondering whether this could be weird for the player. I'd say it'd be okay to send it to the server right away, it's not that much traffic. This way for example, a player could change his name and directly ask their friends what they think about the name. Now they'd ask and their friends would be confused saying "your name didn't" change.
The text was updated successfully, but these errors were encountered: