Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not call scoutapm_enable_instrumentation unless monitoring is enabled #275

Closed
asgrim opened this issue Jun 30, 2022 · 1 comment
Closed

Do not call scoutapm_enable_instrumentation unless monitoring is enabled #275

asgrim opened this issue Jun 30, 2022 · 1 comment
Assignees
@asgrim
Labels
enhancement New feature or request

Comments

@asgrim
Copy link
Collaborator

asgrim commented Jun 30, 2022

heroku/heroku-buildpack-php#390 (comment)

In responding to this query, I noticed that as soon as \Scoutapm\Extension\PotentiallyAvailableExtensionCapabilities is created, the scoutapm_enable_instrumentation(true); call is made, regardless of whether monitoring is enabled.

If monitoring is disabled (e.g. SCOUT_MONITOR=false) then the ext should NOT be enabled.
@asgrim asgrim added the enhancement New feature or request label Jun 30, 2022
@asgrim asgrim mentioned this issue Jun 30, 2022
Open
@asgrim asgrim self-assigned this Jul 6, 2022
@asgrim asgrim mentioned this issue Jul 6, 2022
Merged
@asgrim
Copy link
Collaborator Author

asgrim commented Aug 23, 2022

Fixed in #278

@asgrim asgrim closed this as completed Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asgrim asgrim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asgrim