Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate & Document installation on Heroku #46

Open
cschneid opened this issue Nov 4, 2019 · 7 comments
Open

Investigate & Document installation on Heroku #46

cschneid opened this issue Nov 4, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@cschneid
Copy link

cschneid commented Nov 4, 2019

It's important that we can support Heroku deploys of our agent fully, which includes this native extension.

It seems probable that adding "ext-scoutapm": "*" to composer.json will "just work", but we need to try it, and then document it here and in Scout's docs.

@asgrim asgrim added enhancement New feature or request question Further information is requested labels Nov 4, 2019
@lchachurski
Copy link

There is a predefined list of extensions that can be enabled through composer.json https://devcenter.heroku.com/articles/php-support#extensions

I think the only way at the moment would be to build a custom buildpack for heroku, more here

heroku/heroku-buildpack-php#235 (comment)
https://github.com/heroku/heroku-buildpack-php/blob/master/support/build/README.md

@asgrim
Copy link
Collaborator

asgrim commented Dec 10, 2019

Indeed; I've just verified it doesn't work out the box:

WARNING: A requested extension is not available

and

composer.json/composer.lock requires ext-scoutapm * -> no matching package found.

@asgrim
Copy link
Collaborator

asgrim commented Dec 10, 2019

Here's me thinking "there must be a better way".... heroku/heroku-buildpack-php#377

@asgrim asgrim self-assigned this Dec 10, 2019
@asgrim
Copy link
Collaborator

asgrim commented Dec 11, 2019

I prepared a branch to heroku-buildpack-php to add support for scoutapm - probably makes sense to wait for PHP 7.4 to be out though, and also to ensure we resolve our issue with spans.

(ref: https://github.com/heroku/heroku-buildpack-php/compare/master...asgrim:add-scoutapm-ext?expand=1)

@lchachurski
Copy link

Thanks for the effort, let me know once it's open so we can organize another "thumbs up" campaign to speed things up ;)

@cschneid
Copy link
Author

Note: the newly released scout-apm-php version 2.1.1 (and underlying CoreAgent 1.2.7) solves the mentioned issue with the extension + spans happening too early.

@asgrim
Copy link
Collaborator

asgrim commented Feb 18, 2020

Submitted patch to add scoutapm to Heroku: heroku/heroku-buildpack-php#390

@asgrim asgrim removed the question Further information is requested label Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants