Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Add a default mssql provisioner #195

Open
mathieu-benoit opened this issue Oct 18, 2024 · 3 comments · May be fixed by #235
Open

[feature request] Add a default mssql provisioner #195

mathieu-benoit opened this issue Oct 18, 2024 · 3 comments · May be fixed by #235
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Oct 18, 2024

Let's add a default mssql provisioner, with outputs:

  • connection

For references:

A basic compose file to take inspiration from, could be something around this:

version: '3.8'
services:
  sql-server:
    image: mcr.microsoft.com/mssql/server
    container_name: sql-server-container
    environment:
      SA_PASSWORD: <your_password_here>
      ACCEPT_EULA: Y
    ports:
      - "1433:1433"

Need to be tested and adapted, source file: https://github.com/score-spec/score-compose/blob/main/internal/command/default.provisioners.yaml.

@mathieu-benoit mathieu-benoit added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 18, 2024
@mathieu-benoit
Copy link
Contributor Author

JFYI: now in score-k8s: score-spec/score-k8s#73, so this one would be a really good one for more consistency between score-compose and score-k8s.

@lekaf974
Copy link

lekaf974 commented Jan 5, 2025

@mathieu-benoit will give it a try if it is still needed

@mathieu-benoit
Copy link
Contributor Author

@lekaf974, yes please go ahead, thanks!

JFYI also, now implemented in score-k8s: score-spec/score-k8s#73.

@lekaf974 lekaf974 linked a pull request Jan 9, 2025 that will close this issue
7 tasks
@mathieu-benoit mathieu-benoit moved this from Todo to In Progress in KubeCon EU 2025 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants