Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License/usage in FAQ, answer keys, missing link #86

Open
troycomi opened this issue Apr 11, 2024 · 0 comments
Open

License/usage in FAQ, answer keys, missing link #86

troycomi opened this issue Apr 11, 2024 · 0 comments

Comments

@troycomi
Copy link

This material is great! I really enjoy the toy repo to practice doing reviews in a low-stakes environment. I know new users sometimes feel like their repos have to be perfect, so practicing in a sandbox is a great idea and well implemented with github actions. After reading through I had a few questions/suggestions. Sorry for making this a bad PR, most of these are minor.

License and usage in FAQ

I'd be interested in using at least one example in the INTERSECT module on code review during in-person lecture (and link your page in the materials). Can you add an FAQ section on your licensing policy for usage for classrooms and workshops?

Answer Keys?

You did a great job covering the mechanics of reviewing but spent less time on what a suitable review looks like. What do you think of including a completed exercise repo with comments on the PR along with some guidelines? Maybe even some good and bad example reviews on the same PR?

Missing Link

Super minor, but the forward link on the reviewing page points to the FAQ instead of finding community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant