You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This material is great! I really enjoy the toy repo to practice doing reviews in a low-stakes environment. I know new users sometimes feel like their repos have to be perfect, so practicing in a sandbox is a great idea and well implemented with github actions. After reading through I had a few questions/suggestions. Sorry for making this a bad PR, most of these are minor.
License and usage in FAQ
I'd be interested in using at least one example in the INTERSECT module on code review during in-person lecture (and link your page in the materials). Can you add an FAQ section on your licensing policy for usage for classrooms and workshops?
Answer Keys?
You did a great job covering the mechanics of reviewing but spent less time on what a suitable review looks like. What do you think of including a completed exercise repo with comments on the PR along with some guidelines? Maybe even some good and bad example reviews on the same PR?
Missing Link
Super minor, but the forward link on the reviewing page points to the FAQ instead of finding community.
The text was updated successfully, but these errors were encountered:
This material is great! I really enjoy the toy repo to practice doing reviews in a low-stakes environment. I know new users sometimes feel like their repos have to be perfect, so practicing in a sandbox is a great idea and well implemented with github actions. After reading through I had a few questions/suggestions. Sorry for making this a bad PR, most of these are minor.
License and usage in FAQ
I'd be interested in using at least one example in the INTERSECT module on code review during in-person lecture (and link your page in the materials). Can you add an FAQ section on your licensing policy for usage for classrooms and workshops?
Answer Keys?
You did a great job covering the mechanics of reviewing but spent less time on what a suitable review looks like. What do you think of including a completed exercise repo with comments on the PR along with some guidelines? Maybe even some good and bad example reviews on the same PR?
Missing Link
Super minor, but the forward link on the reviewing page points to the FAQ instead of finding community.
The text was updated successfully, but these errors were encountered: