Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batched sampling from MDNs not working correctly #1224

Closed
janfb opened this issue Aug 19, 2024 · 1 comment
Closed

batched sampling from MDNs not working correctly #1224

janfb opened this issue Aug 19, 2024 · 1 comment
Assignees
@janfb
Labels
bug Something isn't working
Milestone
Hackathon and rel...

Comments

@janfb
Copy link
Contributor

janfb commented Aug 19, 2024 •
edited
Loading

Describe the bug
There is a bug in pyknos resulting in mixed up samples with using a batch size larger than one.

I will make a PR in pyknos to fix this.

To Reproduce
See new test in posterior_nn_test.py, marked as xfail, added in #1221
@janfb janfb added the bug Something isn't working label Aug 19, 2024
@janfb janfb self-assigned this Aug 19, 2024
@janfb
Copy link
Contributor Author

janfb commented Aug 19, 2024

will be fixed by sbi-dev/pyknos#36

@janfb janfb added this to the Hackathon and release 0.23 milestone Aug 19, 2024
janfb added a commit that referenced this issue Aug 20, 2024
@janfb
fix #1224: upgrade pyknos, remove xfail test.
0bcd820
janfb added a commit that referenced this issue Aug 20, 2024
@janfb
fix #1224: upgrade pyknos, remove xfail test.
867c10a
@janfb janfb closed this as completed in 72b3a7d Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janfb janfb

Labels
bug Something isn't working
Projects
None yet
Milestone
Hackathon and release 0.23
Development

No branches or pull requests
1 participant
@janfb