Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check and lock commands as pre-commit hooks #4

Open
mourtisma opened this issue Mar 22, 2021 · 1 comment
Open

Add check and lock commands as pre-commit hooks #4

mourtisma opened this issue Mar 22, 2021 · 1 comment

Comments

@mourtisma
Copy link

I think it would be a good idea to add dante check and dante lock as pre-commit hooks, using the pre-commit framework.

  • Default requirement files would be requirements-dev.txt and requirements.txt
  • Default requirement files would be requirements-dev.lock and requirements.lock

While running the hook, this configuration could be overriden by the developers, either trough pre-commit's args option, or their own setup.cfg

If you agree with this, I can write the PR myself.
@mourtisma
Copy link
Author

Any feedback about this idea ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mourtisma