Crash from requests.dynamic fed with requests with network URIs instead of files.

[AEManov20]

Greetings,

In my script i have a requests.dynamic variable which stores the main song queue of the radio with prefetch = 2. It fetches the songs from the following function:

def request_handler()
    if list.is_empty(playlist_filenames) then
        error.raise(error.not_found, "Playlist is empty")
    elsif is_shuffle() then
        request.create(list.pick(playlist_filenames))
    else
        request.create(list.nth(playlist_filenames, get_current_index()))
    end
end

The playlist_filenames variable is a list with all of the playlist's songs' URIs and the function just goes over the list in order and then loops over when the playlist is over. The behaviour of course is different when is_shuffle() is true.
During runtime after the 2nd song is over the script crashes (stack trace below) and the error seems to originate from Request.initial_uri being None.
This error popped up amidst the process of migrating from Liquidsoap version 2.2.5 to 2.3.0. The same script works perfectly fine on 2.2.5.

Any ideas where the error could originate from?

Thanks in advance!

Stack trace:

Thread 2 killed on uncaught exception Assert_failure("src/core/request.ml", 121, 14)
Raised at Request.initial_uri in file "src/core/request.ml", line 121, characters 14-26
Called from Request_dynamic.log_failed_request in file "src/core/sources/request_dynamic.ml", line 49, characters 4-33
Called from Stdlib__List.iter in file "list.ml", line 110, characters 12-15
Called from Request_dynamic.(fun) in file "src/core/sources/request_dynamic.ml", line 433, characters 16-29
Called from Liquidsoap_lang__Evaluation.apply.f in file "src/lang/evaluation.ml", line 113, characters 8-12
Called from Liquidsoap_lang__Evaluation.eval_term in file "src/lang/evaluation.ml", line 327, characters 10-43
Called from Liquidsoap_lang__Evaluation.eval in file "src/lang/evaluation.ml", line 336, characters 10-38
Called from Liquidsoap_lang__Evaluation.eval_term in file "src/lang/evaluation.ml", line 327, characters 10-43
Called from Liquidsoap_lang__Evaluation.eval in file "src/lang/evaluation.ml", line 336, characters 10-38
Called from Liquidsoap_lang__Evaluation.eval_term in file "src/lang/evaluation.ml", line 327, characters 10-43
Called from Liquidsoap_lang__Evaluation.eval in file "src/lang/evaluation.ml", line 336, characters 10-38
Called from Liquidsoap_lang__Evaluation.apply.f in file "src/lang/evaluation.ml", line 113, characters 8-12
Called from Liquidsoap_lang__Evaluation.apply.f in file "src/lang/evaluation.ml", line 113, characters 8-12
Called from Liquidsoap_lang__Evaluation.eval_term in file "src/lang/evaluation.ml", line 327, characters 10-43
Called from Liquidsoap_lang__Evaluation.eval in file "src/lang/evaluation.ml", line 336, characters 10-38
Called from Liquidsoap_lang__Evaluation.apply.f in file "src/lang/evaluation.ml", line 113, characters 8-12
Called from Liquidsoap_lang__Evaluation.eval_term in file "src/lang/evaluation.ml", line 327, characters 10-43
Called from Liquidsoap_lang__Evaluation.eval in file "src/lang/evaluation.ml", line 336, characters 10-38
Called from Liquidsoap_lang__Evaluation.eval_base_term in file "src/lang/evaluation.ml", line 301, characters 15-39
Called from Liquidsoap_lang__Evaluation.eval_term in file "src/lang/evaluation.ml", line 327, characters 10-43
Called from Liquidsoap_lang__Evaluation.eval in file "src/lang/evaluation.ml", line 336, characters 10-38
Called from Liquidsoap_lang__Evaluation.apply.f in file "src/lang/evaluation.ml", line 113, characters 8-12
Called from Liquidsoap_lang__Lang_core.apply in file "src/lang/lang_core.ml" (inlined), line 264, characters 21-40
Called from Lang_source.source_methods.(fun) in file "src/core/lang_source.ml", line 269, characters 40-68
Called from Source.operator#execute_on_track.(fun) in file "src/core/source.ml" (inlined), line 471, characters 29-33
Called from Stdlib__List.iter in file "list.ml", line 110, characters 12-15
Called from Source.operator#instrumented_generate_frame in file "src/core/source.ml", line 566, characters 29-54
Called from Source.operator#before_streaming_cycle.(fun) in file "src/core/source.ml", line 337, characters 43-75
Called from Source.operator#peek_frame in file "src/core/source.ml", line 369, characters 12-17
Called from Source.operator#get_partial_frame in file "src/core/source.ml", line 374, characters 20-35
Called from Source.generate_from_multiple_sources#generate_frame in file "src/core/source.ml", line 649, characters 16-37
Called from Source.operator#instrumented_generate_frame in file "src/core/source.ml", line 543, characters 45-64
Called from Source.operator#before_streaming_cycle.(fun) in file "src/core/source.ml", line 337, characters 43-75
Called from Source.operator#peek_frame in file "src/core/source.ml", line 369, characters 12-17
Called from Source.operator#get_partial_frame in file "src/core/source.ml", line 374, characters 20-35
Called from Cross.cross#child_get.(fun) in file "src/core/operators/cross.ml", line 236, characters 14-212
Called from Stdlib__List.iter in file "list.ml", line 110, characters 12-15
Called from Liquidsoap_lang__Queues.Queue.flush_iter in file "src/lang/queues.ml" (inlined), line 33, characters 24-55
Called from Clock._tick in file "src/core/clock.ml", line 406, characters 2-76
Called from Cross.cross#child_get in file "src/core/operators/cross.ml", line 233, characters 6-304
Called from Cross.cross#buffer_before in file "src/core/operators/cross.ml", line 340, characters 24-55
Called from Cross.cross#get_source in file "src/core/operators/cross.ml", line 326, characters 12-49
Called from Source.generate_from_multiple_sources#can_generate_frame in file "src/core/source.ml", line 614, characters 8-101
Called from Source.operator#before_streaming_cycle in file "src/core/source.ml", line 330, characters 37-60
Called from Source.operator#is_ready in file "src/core/source.ml", line 295, characters 8-35
Called from Source.operator#before_streaming_cycle in file "src/core/source.ml", line 330, characters 37-60
Called from Source.operator#is_ready in file "src/core/source.ml", line 295, characters 8-35
Called from Clock_base.self_sync.(fun) in file "src/core/clock_base.ml", line 148, characters 13-23
Called from Stdlib__List.fold_left in file "list.ml", line 121, characters 24-34
Called from Clock_base.self_sync.(fun) in file "src/core/clock_base.ml", line 146, characters 6-319
Called from Switch.switch#self_sync in file "src/core/operators/switch.ml", line 234, characters 26-54
Called from Clock._self_sync.(fun) in file "src/core/clock.ml", line 282, characters 14-25
Called from Stdlib__List.fold_left in file "list.ml", line 121, characters 24-34
Called from Clock._self_sync in file "src/core/clock.ml", line 280, characters 4-272
Called from Clock._after_tick in file "src/core/clock.ml", line 329, characters 17-36
Called from Clock._clock_thread.run in file "src/core/clock.ml", line 438, characters 8-22
Called from Tutils.create.(fun).process in file "src/core/tools/tutils.ml", line 175, characters 12-15
Re-raised at Tutils.create.(fun).process in file "src/core/tools/tutils.ml", line 219, characters 14-52
Called from Thread.create.(fun) in file "thread.ml", line 49, characters 8-14

[toots]

Hi!

Thanks for reporting.

Most likely, this is an exception that should not be surfaced. I think that, due to the logic of your script, some of the request are created empty or failed to resolve. However, the code responsible for logging the failure has a bug that raises an exception.

#4307 should take care of the exception. Once it's merged, the runtime should properly describe the underlying request resolution failure.

[AEManov20]

That's interesting, I have a harbor endpoint in my script which returns the songs' metadata in order of the queue of the request.dynamic variable and the metadata was always an empty object in the result. And that was since the migration to 2.3.0. That probably explains it. Thanks a lot!