Off by one bug in sheets.py?

[frosencrantz]

Is there an off-by-one bug here?:

visidata/visidata/sheets.py

Lines 925 to 926 in 8f823f5

	if x+colwidth+dispwidth(sepchars) <= self.windowWidth:
	scr.addstr(y, x+colwidth, sepchars, sepcattr.attr)

I sometimes get an exception from the scr.addstr(): error: addwstr() returned ERR

I tried removing the = it seems to work better, though I have not tried it long enough to be sure.

[midichef]

Did you see a traceback showing that the exception came from this line? Because the <= operator here seems fine to me when testing with default settings.

I have tested that <= self.windowWidth works when hitting the case of == and not just <, by resizing my terminal window with the mouse to put the column separator | in the rightmost square of the terminal.

Do you have an unusual setting for disp_column_sep? Or maybe an unusual terminal emulator or column width in your data?

There have been other similar errors from other addstr() calls trying to draw offscreen, like #2171, which is a very low priority bug for now. So I'd like to be sure the error came from line 925 before investigating further.

[frosencrantz]

The exception I’m seeing is _curses.error: addwstr() returned ERR

The stack trace to get there is sheets.py:798
y += self.drawRow(scr, row, self.topRowIndex+rowidx, y, rowcattr, maxheight=self.windowHeight-y-1, **drawparams)

From mainloop.py line 28 callNoExceptions return func(*args, **kwargs)

Also, sepchars (and disp_column_sep) is an empty string, I'm trying to get a lot of single character values on the screen, though each one is in a separate column.

[midichef]

Thanks for the detail. The cause was the empty column separator. I've submitted a fix, #2491.

[frosencrantz]

For completeness, this fixed the issue.