Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve field validation #63

Closed
sashirestela opened this issue Mar 15, 2024 · 0 comments · Fixed by #76
Closed

Improve field validation #63

sashirestela opened this issue Mar 15, 2024 · 0 comments · Fixed by #76
Assignees
@sashirestela
Labels
enhancement New feature or request

Comments

@sashirestela
Copy link
Owner

sashirestela commented Mar 15, 2024 •
edited
Loading

Currently, there is minimal field validation and the existing one is made by hand in the constructors. So, the client of this library needs to read the OpenAI API specification to not make errors, which could be avoided if we include full validations.

A nice-to-have option will be to use an external library to handle validations by annotations. This could have the additional benefit to serve as metadata to be compared against the API specification and identify any difference by changes in the OpenAI side.
@sashirestela sashirestela self-assigned this Mar 15, 2024
@sashirestela sashirestela added the enhancement New feature or request label Mar 15, 2024
@sashirestela sashirestela linked a pull request Apr 6, 2024 that will close this issue
Improve field validation #76
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sashirestela sashirestela

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve field validation sashirestela/simple-openai
1 participant
@sashirestela