-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log-info-fix #2026
log-info-fix #2026
Conversation
WalkthroughWalkthroughThe recent changes enhance the logging process within the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Task
participant Logger
User->>Task: Complete Task
activate Task
Task->>Logger: Collect log extras
Logger-->>Task: Log details
Task-->>User: Task completed successfully
deactivate Task
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- spiffworkflow-backend/src/spiffworkflow_backend/services/process_instance_processor.py (1 hunks)
Additional comments not posted (1)
spiffworkflow-backend/src/spiffworkflow_backend/services/process_instance_processor.py (1)
1308-1308
: Update logging method usage.The logging method has been updated to use
collect_log_extras
instead oflog_info
. Ensure thatcollect_log_extras
provides the necessary log details.
Fixes #1927 (comment)
It looks like the
log_info
method was changed tocollect_log_extras
in sartography/SpiffWorkflow@e959112 so use that.Summary by CodeRabbit