From 3a210735aa34f26d92c199aeee588dc793cb54da Mon Sep 17 00:00:00 2001 From: Sarbagya Dhaubanjar Date: Fri, 20 Sep 2024 07:31:36 +0545 Subject: [PATCH] Version Bump (#996) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix navigation pop error by canceling PopScope action if pop is alredy confirmed * - Refactor PopScope to pop if the player is not in fullscreen instead of always false. - Remove `Navigator.pop` inside `onPopInvokedWithResult` to avoid issues with external navigation (Example: Pressing dialog barrier, or using an external navigation solution) * :art: formaating fixes * fix: Full Screen in Landscape mode cut the video #621 (#962) * Full Screen in Landscape mode cut the video #621 * Full Screen in Landscape mode cut the video #621 * :art: minor changes * :bookmark: bumped version * minor change --------- Co-authored-by: RaphiTobi Co-authored-by: abulmajd Co-authored-by: Nhật Long <116779782+longtn-imt@users.noreply.github.com> --- packages/youtube_player_flutter/CHANGELOG.md | 3 +++ .../lib/src/widgets/youtube_player_builder.dart | 7 ++++--- packages/youtube_player_flutter/pubspec.yaml | 4 ++-- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/packages/youtube_player_flutter/CHANGELOG.md b/packages/youtube_player_flutter/CHANGELOG.md index 473f3a77..acd4a529 100644 --- a/packages/youtube_player_flutter/CHANGELOG.md +++ b/packages/youtube_player_flutter/CHANGELOG.md @@ -1,3 +1,6 @@ +## 9.0.4 +* Fixes related to fullscreen toggle. + ## 9.0.3 * Fixes issue where loading indicator would always show. * Updates the default color of the progress indicator to be primary container color. diff --git a/packages/youtube_player_flutter/lib/src/widgets/youtube_player_builder.dart b/packages/youtube_player_flutter/lib/src/widgets/youtube_player_builder.dart index 72740f92..426117c6 100644 --- a/packages/youtube_player_flutter/lib/src/widgets/youtube_player_builder.dart +++ b/packages/youtube_player_flutter/lib/src/widgets/youtube_player_builder.dart @@ -67,11 +67,12 @@ class _YoutubePlayerBuilderState extends State @override Widget build(BuildContext context) { - final double height = MediaQuery.of(context).size.height; + final orientation = MediaQuery.orientationOf(context); + final height = MediaQuery.sizeOf(context).height; - final player = Container( + final player = SizedBox( key: playerKey, - height: (MediaQuery.of(context).orientation == Orientation.landscape) ? height : null, + height: orientation == Orientation.landscape ? height : null, child: PopScope( canPop: !widget.player.controller.value.isFullScreen, onPopInvokedWithResult: (didPop, _) { diff --git a/packages/youtube_player_flutter/pubspec.yaml b/packages/youtube_player_flutter/pubspec.yaml index 7cef645b..970c707e 100644 --- a/packages/youtube_player_flutter/pubspec.yaml +++ b/packages/youtube_player_flutter/pubspec.yaml @@ -1,6 +1,6 @@ name: youtube_player_flutter description: Flutter plugin for playing or streaming inline YouTube videos using the official iFrame player API. This plugin supports both Android and iOS. -version: 9.0.3 +version: 9.0.4 repository: https://github.com/sarbagyastha/youtube_player_flutter homepage: https://github.com/sarbagyastha/youtube_player_flutter/tree/master/packages/youtube_player_flutter @@ -16,7 +16,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter - mocktail: ^1.0.3 + mocktail: ^1.0.4 flutter: uses-material-design: true