Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelations with the same canonical form #304

Open
wwitzel opened this issue Oct 9, 2022 · 0 comments
Open

Cancelations with the same canonical form #304

wwitzel opened this issue Oct 9, 2022 · 0 comments

Comments

@wwitzel
Copy link
Collaborator

wwitzel commented Oct 9, 2022

Rather than ensuring sub-expressions are identical in order to cancel them (in a sum or product/division), we can do this based upon canonical forms. This has been implemented for Add (in the QPE_finale_witzel branch) but not yet for Mult and Divide. Cancelation theorems need to be changed for this to work flexibly. For example,
image
rather than just having "a - a = 0". The same needs to be done for multiplicative cancelations.
wwitzel added a commit that referenced this issue Oct 9, 2022
@wwitzel
Use canonical forms for Add cancelations
4aff5ed 
Implement canceling terms based upon having the same canonical form rather than being identical.  Implements part of Issue #304.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wwitzel