Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Unit Tests in TestMirrorOutput and TestSolarFieldOutput #109

Closed
braden6521 opened this issue May 29, 2024 · 6 comments
Closed

Failing Unit Tests in TestMirrorOutput and TestSolarFieldOutput #109

braden6521 opened this issue May 29, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@braden6521
Copy link
Collaborator

The following unit tests fail on Windows2022. These errors are not reproducible locally.

  • TestMirrorOutput::test_heliostat_05W01_and_14W01
  • TestMirrorOutput::test_solar_field
  • TestRayTraceOutput::test_changing_time_of_day
  • TestSolarFieldOutput::test_multi_heliostat
  • TestSolarFieldOutput::test_solar_field_subset
@braden6521 braden6521 added the bug Something isn't working label May 29, 2024
@braden6521
Copy link
Collaborator Author

braden6521 commented May 29, 2024

@bbean23, @e10harvey: I cannot figure out why these failures are occurring. You can see these failures hanging up the following PRs:

@e10harvey e10harvey self-assigned this May 29, 2024
@e10harvey
Copy link
Collaborator

e10harvey commented May 29, 2024

@braden6521: Are these unit test failures spurious?

@e10harvey
Copy link
Collaborator

Triage notes:

  • This happens with both python3.10 and python3.11
  • ubi8 is using and passing with matplotlib version 3.8.4
  • windows2022 is using matplotlib version 3.9.0 (matplotlib-inline-0.1.7)
  • These tests last passed in windows2022 with matplotlib version 3.8.4 (matplotlib-inline-0.1.7)

e10harvey added a commit to e10harvey/OpenCSP that referenced this issue May 29, 2024
@braden6521
Copy link
Collaborator Author

@e10harvey, no these happen very regularly. These specific five unit test every time.

@e10harvey
Copy link
Collaborator

e10harvey commented May 29, 2024

@e10harvey, no these happen very regularly. These specific five unit test every time.

Ok, thank you. e10harvey@34c94df resolves this issue. Once #95 merges, it should be fixed.

@e10harvey
Copy link
Collaborator

Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants