StorageAdapter#upload_file/StorageAdapter#find_by shouldn't open handles #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackartisan
requested changes
Oct 18, 2021
| @@ -30,6 +30,24 @@ class Valkyrie::Specs::CustomResource < Valkyrie::Resource | |||
| expect(uploaded_file.valid?(digests: { sha1: sha1 })).to be true | |||
| end | |||
|
|
|||
| it "doesn't open a file handle on discovery" do | |||
There was a problem hiding this comment.
Expand the title to include the "doesn't leave a file handle open on upload" piece
| pre_open_files = open_files | ||
| the_file = storage_adapter.find_by(id: uploaded_file.id) | ||
| expect(the_file).to be_kind_of Valkyrie::StorageAdapter::File | ||
| # the_file.io |
lib/valkyrie/storage/disk.rb
Outdated
| rescue Errno::ENOENT | ||
| raise Valkyrie::StorageAdapter::FileNotFound | ||
| end | ||
|
|
||
| ## Lazy file takes open parameters but doesn't open up a file handle. This |
There was a problem hiding this comment.
maybe say "doesn't leave an open file handle"
hackartisan
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #869
This has been tested in Figgy here: https://github.com/pulibrary/figgy/compare/test_new_storage_adapter_requirements