Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared specs for lock token messages should be less stringent. #849

Closed
tpendragon opened this issue Mar 24, 2021 · 0 comments · Fixed by #877
Closed

Shared specs for lock token messages should be less stringent. #849

tpendragon opened this issue Mar 24, 2021 · 0 comments · Fixed by #877

Comments

@tpendragon
Copy link
Collaborator

See:

expect { persister.save(resource: resource) }.to raise_error(Valkyrie::Persistence::StaleObjectError, "The object #{resource.id} has been updated by another process.")

and

.to raise_error(Valkyrie::Persistence::StaleObjectError, "One or more resources have been updated by another process.")

Hyrax wanted to add more information to their messages but was unable to. See https://github.com/samvera/hyrax/pull/4826/files#diff-73caa203a9c5c992790524775b0d7251a4490cbb154382cdb2a5483019bf0e4aR47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant