Use Lando for Development #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpendragon
force-pushed
the
lando_dev_setup
branch
from
e1e89da to
fc08f9f
Compare
This significantly improves our startup experience, and has been in use at Princeton for a while now.
tpendragon
force-pushed
the
lando_dev_setup
branch
from
fc08f9f to
b9a0454
Compare
escowles
reviewed
Oct 20, 2020
|
|
||
| ### Running Tests | ||
|
|
||
| 1. Install the latest released > 3.0 version of Lando from [here](https://github.com/lando/lando/releases). |
There was a problem hiding this comment.
Do we want to include Homebrew or other instructions for this? There were some before, and the docker dependencies are still required here. brew install docker docker-machine docker-compose lando worked for me.
There was a problem hiding this comment.
The Lando installer should install docker for you, so I don't think that should be necessary
|
👍 This got the docker-based test machinery working for me for the first time. |
|
👍 works for me, tests pass. |
hackartisan
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly improves our startup experience, and has been in use
at Princeton for a while now.
resolves #838