Renaming Blacklist to Denylist #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
previously approved these changes
Jun 8, 2020
|
This is failing ci with: |
|
Yeah. I'm trying to get my local build environment up and running to
address this code coverage requirement.
…On Mon, Jun 8, 2020 at 10:49 AM Justin Coyne ***@***.***> wrote:
This is failing ci with:
Line coverage (99.84%) is below the expected minimum coverage (100.00%).
SimpleCov failed with exit 2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#833 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAQUW4C2ANJTI7F5MORULRVT3AHANCNFSM4NYPCT2Q>
.
--
Jeremy Friesen
takeonrules.com
|
|
This is great! Thank you. Just needs a test to make sure the deprecation message shows up. I can add it if you'd like. |
jeremyf
force-pushed
the
gh-832-rename-blacklist-to-denylist
branch
2 times, most recently
from
4e953b3 to
8d495ac
Compare
Prior to this commit, our language of Blacklist perpetuated the idea that "black" is not allowed. This change clarifies the purpose without relying on discriminatory cultural jargon (e.g. blacklist/whitelist). In addition, by using a clear term, we make the intention more accessible. Closes #832
jeremyf
force-pushed
the
gh-832-rename-blacklist-to-denylist
branch
from
8d495ac to
6c7e77a
Compare
tpendragon
approved these changes
Jun 8, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, our language of Blacklist perpetuated the idea
that "black" is not allowed. This change clarifies the purpose without
relying on discriminatory cultural jargon (e.g. blacklist/whitelist). In
addition, by using a clear term, we make the intention more accessible.
Closes #832