Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shared ChangeSet spec. #823

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Fix shared ChangeSet spec. #823

merged 1 commit into from
Feb 10, 2020

Conversation

tpendragon
Copy link
Collaborator

Closes #822

coblej
coblej approved these changes Feb 10, 2020
View reviewed changes
Copy link

@coblej coblej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. I'm fairly new to the optimistic locking functionality so you might want someone more familiar with it than me to take a look as well.

@tpendragon tpendragon merged commit be055e0 into master Feb 10, 2020
@tpendragon tpendragon deleted the change_set_shared_spec branch February 10, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coblej coblej coblej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change set shared spec assumes resource does not have optimistic locking enabled
2 participants
@tpendragon @coblej