Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change set shared spec assumes resource does not have optimistic locking enabled #822

Closed
coblej opened this issue Feb 10, 2020 · 1 comment · Fixed by #823
Closed

Change set shared spec assumes resource does not have optimistic locking enabled #822

coblej opened this issue Feb 10, 2020 · 1 comment · Fixed by #823
Labels

Comments

@coblej
Copy link

coblej commented Feb 10, 2020

This change set shared spec -- https://github.com/samvera/valkyrie/blob/v2.0.2/lib/valkyrie/specs/shared_specs/change_set.rb#L76-L80 -- assumes that optimistic locking is not enabled on the underlying resource. When the shared spec is used in downstream applications, it will pass or fail depending on whether the resource in the application has optimistic locking enabled or not.

@coblej coblej added the bug label Feb 10, 2020
@coblej
Copy link
Author

coblej commented Feb 10, 2020

Perhaps a better expectation for this test would be expect(change_set.optimistic_locking_enabled?).to eq change_set.resource.optimistic_locking_enabled? ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant