From 98127430caf969385d8e5e3a16007d9879044d98 Mon Sep 17 00:00:00 2001 From: smartcontracts Date: Tue, 1 Oct 2024 14:07:44 -0400 Subject: [PATCH] fix(ci): temporarily make semgrep scan ok on err (#12227) Temporarily makes semgrep-scan not fail on error. Currently this is a problem for external contributions because semgrep-scan loads rules from the online app which requires a login. External contributors don't get access to this login. --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3d8c25faa5cc0..c4da7cb22ebb5 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1167,7 +1167,7 @@ jobs: # --timeout (in seconds) limits the time per rule and file. # SEMGREP_TIMEOUT is the same, but docs have conflicting defaults (5s in CLI flag, 1800 in some places) # https://semgrep.dev/docs/troubleshooting/semgrep-app#if-the-job-is-aborted-due-to-taking-too-long - command: semgrep ci --timeout=100 --no-suppress-errors + command: semgrep ci --timeout=100 # If semgrep hangs, stop the scan after 20m, to prevent a useless 5h job no_output_timeout: 20m - notify-failures-on-develop