You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, congrats for this new automation library, I've been looking at it for quite some times, and now I'have had the opportunity to play a bit with, and it's really cool.
I have a minor issue (more of an inconvenience, really).
I think capture.save_capture(), capture.export_.....() functions should accept pathlib.Path object as parameter, since it is part of the standard library.
This gives a TypeError: bad argument type for built-in operation (which by the way is not the most clear error ever. . .)
Obviously, the fix could be straightforward :
def save_capture(self, filepath: str|pathlib.Path):
"""
Saves the capture to a .sal file, which can be loaded later either through the UI or with the load_capture() function.
:param filepath: path to the .sal file. Can be absolute, or relative to the Logic 2 software current working directory.
"""
request = saleae_pb2.SaveCaptureRequest(
capture_id=self.capture_id, filepath=str(filepath)
)
Best regards.
The text was updated successfully, but these errors were encountered:
Hello,
First, congrats for this new automation library, I've been looking at it for quite some times, and now I'have had the opportunity to play a bit with, and it's really cool.
I have a minor issue (more of an inconvenience, really).
I think capture.save_capture(), capture.export_.....() functions should accept pathlib.Path object as parameter, since it is part of the standard library.
This gives a
TypeError: bad argument type for built-in operation
(which by the way is not the most clear error ever. . .)Obviously, the fix could be straightforward :
Best regards.
The text was updated successfully, but these errors were encountered: