Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Link-Time Optimization (LTO) #1202

Open
zamazan4ik opened this issue Dec 19, 2024 · 2 comments · May be fixed by #1211
Open

Enable Link-Time Optimization (LTO) #1202

zamazan4ik opened this issue Dec 19, 2024 · 2 comments · May be fixed by #1211
Assignees

Comments

@zamazan4ik
Copy link

Feature Description

I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a little bit. If you want to read more about LTO and its possible modes, I recommend starting from this Rustc documentation.

I think you can enable LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where in addition to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most optimized version of the application. However, if we enable it on the Cargo profile level for the Release profile, users, who install the application with cargo install will get the LTO-optimized version of the game "automatically". E.g., check cargo-outdated Release profile. You also could be interested in other optimization options like codegen-units = 1, etc. If you are still concerned by the build times, you can switch to ThinLTO.

Describe The Solution You'd Like

Basically, it can be enabled with the following lines:

[profile.release]
lto = true

I have made quick tests (Fedora 41, Rust 1.82, the latest version of the project) by adding lto = true to the Release profile. For both binaries (cargo-make and makers) the binary size reduction is from 13 Mib to 11 Mib.

Code Sample

N/A

@sagiegurari
Copy link
Owner

thanks. @zamazan4ik would you like to PR this?

@zamazan4ik
Copy link
Author

Sure: #1211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants