Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support gitlab proxying #6094

Closed
williamstein opened this issue Aug 31, 2022 · 1 comment
Closed

support gitlab proxying #6094

williamstein opened this issue Aug 31, 2022 · 1 comment
Labels
A-jupyter A-next A-share share server; making things public; user generated content I-enhancement

Comments

@williamstein
Copy link
Contributor

Somebody tried to share a notebook from gitlab here:

https://cocalc.com/url/gitlab.com/sanhuoHQ/123/-/blob/main/DCGNN.ipynb

It doesn't work, but we could make it work in a similar way to github. Note that upstream https://nbviewer.org/ doesn't support gitlab, though there was a feature request to add gitlab support... in 2014! jupyter/nbviewer#371
Also jupyter/nbviewer#879
@williamstein williamstein added I-enhancement A-jupyter A-share share server; making things public; user generated content A-next labels Aug 31, 2022
@williamstein
Copy link
Contributor Author

Gitlab is less and less popular. Proxying url's is a major abuse vector. If anything, we should consider eliminating proxying github, not adding more abuse opportunities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-jupyter A-next A-share share server; making things public; user generated content I-enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@williamstein