Add check for zero monomial in monomial_coefficient #39256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 9230780; changes) is ready! 🎉 |
keltecc
force-pushed
the
fix-monomial-coefficient
branch
from
27f754a to
d0fe6f3
Compare
|
does it work with "is NULL" ? there is no final dot at the end of error messages (it's a Python general convention) |
|
Thank you for review, fixed.
It works.
I tried to keep consistency with another error message in this function: if mon._parent is not self._parent:
raise TypeError("mon must have same parent as self.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39255
Added check for zero monomial and corresponding test case.
📝 Checklist
⌛ Dependencies