fix m prototype #175
Merged
fix m prototype #175
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi, I don't know how cypari is implemented, but this looks reasonable to me. Note that in gp, if the result of the function with prototype m is not returned to the user (for instance it is immediately used in another function call) then we don't do the gcopy. I don't know whether this is possible in cypari. I will also show the patch to Bill. |
|
Bill says that if new_gen makes a copy then gcopy is unnecessary. But seeing #133 it seems that this is not the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of #134, just use the important commit. This will fix #133