You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our current prices provider (CoinGecko) seemingly has a limit for the number of token prices that can be requested at once, throwing an error if this is breached:
We should incrementally fetch prices based on the provider limit and concatenate them accordingly. We should also add warnings specific to the error code, should this limit be changed without us knowing.
Note: receiving spam tokens can cause su
Reproduction steps
Fetch the balances on a Safe with a high number of assets, e.g. eth:0x220866b1a2219f40e72f5c628b65d54268ca3a9d or gno:0xB8d760a90a5ed54D3c2b3EFC231277e99188642A (the latter has a lot of spam tokens).
Oberve the datasource error from CoinGecko (the following is taken upon creation of this issue):
Description
Our current prices provider (CoinGecko) seemingly has a limit for the number of token prices that can be requested at once, throwing an error if this is breached:
If this happens, an empty array of token prices is returned by the datasource, meaning that fiat balances are 0.
We should incrementally fetch prices based on the provider limit and concatenate them accordingly. We should also add warnings specific to the error code, should this limit be changed without us knowing.
Note: receiving spam tokens can cause su
Reproduction steps
eth:0x220866b1a2219f40e72f5c628b65d54268ca3a9d
orgno:0xB8d760a90a5ed54D3c2b3EFC231277e99188642A
(the latter has a lot of spam tokens).Expected behavior
null
to signifiy we aren't aware of the price.Additional information
Caching currently occurs based on the provided list, rather than a more "stable" key. We should consider making #2273 a prerequisite for this.
The text was updated successfully, but these errors were encountered: