Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support private registries #51

Open
mercxry opened this issue Feb 3, 2023 · 6 comments
Open

feature: support private registries #51

mercxry opened this issue Feb 3, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@mercxry
Copy link

mercxry commented Feb 3, 2023

Hello, I use a private registry for some crates at work, unfortunately this plugin is not able to fetch the crate versions from there.

Are there plans to support private registries?

Screen Shot 2023-02-03 at 15 05 44

@saecki
Copy link
Owner

saecki commented Feb 13, 2023

That sounds reasonable, I'll see what I can do

@LeonKowarschickKenbun
Copy link

Any updates? I'd be happy to take a look myself, if you're busy ^^

@saecki
Copy link
Owner

saecki commented Mar 2, 2023

Yeah, sorry I'm currently quite swamped, feel free

@saecki saecki added the enhancement New feature or request label Mar 11, 2023
@stvndall
Copy link

Stumbled onto this plugin, it's awesome, but I also use a custom registry.

Having just found the plugin, it will take me a while to familiarise myself with the code, and make any changes. @LeonKowarschickKenbun Did you manage to take a look at all?

@LeonKowarschickKenbun
Copy link

Not yet, sadly

@saecki
Copy link
Owner

saecki commented May 12, 2023

Here are some thoughts as to how this could be implemented

  • First we have to parse the registry declaration in the toml module and store it on the Crate struct
  • Then we need to obtain the user defined registries
    • global ones stored in the user home
    • and local ones stored in the repository
    • they should probably be lazy loaded when fetching metadata, since this involves FS operations
  • Lastly we just pass the whole crate struct to the functions in the API module which decide where to fetch metadata from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants