Refactor withdrawMultiple
to in include block.timestamp
#53
Closed
smol-ninja
started this conversation in
General
Replies: 2 comments 2 replies
-
i don't think i understand this point why don't we add function withdrawMultiple(uint256[] calldata streamIds, uint40[] calldata times) external; |
Beta Was this translation helpful? Give feedback.
2 replies
-
Issue created: |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Motivation
time
cannot trigger a full withdrawal due to unpredictability ofblock.timestamp
That is why I suggest to remove
uint40[] calldata times
from it and useblock.timestamp
instead.instead of
Side note: If a user intents to include
time
inwithdrawMultiple
, they can do it programatically usingwithdraw
function.Beta Was this translation helpful? Give feedback.
All reactions