Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labels/numbering #127

Open
4 of 5 tasks
thosgood opened this issue Jan 26, 2020 · 9 comments
Open
4 of 5 tasks

labels/numbering #127

thosgood opened this issue Jan 26, 2020 · 9 comments
Assignees
Labels
web Anything related to the website

Comments

@thosgood
Copy link
Collaborator

thosgood commented Jan 26, 2020

a few things which i think could probably all be dealt with at the same time:

  1. "labels" are doubled: e.g. — 2.8.7.1 (8.7.1).
  2. the table of contents at https://ega.fppf.site/browse doesn't seem to go any deeper than just the part level
  3. it would maybe be nice to switch the part numbering to roman numerals? so that we have II.8.7.1 etc.
  4. the env environment looks a bit odd in the table of contents (see image), but i'm not too sure what a better name for it would be...
  5. as in the image, environments in the TOC also have their 'title', but since this is just the number again, it might be nice to surpress it?

Screenshot 2020-01-26 at 21 15 47

@thosgood thosgood added the web Anything related to the website label Jan 26, 2020
@ryankeleti
Copy link
Owner

part 1 is done

@ryankeleti
Copy link
Owner

b0ec31d. all labels in project now use roman.x.y.z so it looks better. I'll get around to finishing part 3

@thosgood
Copy link
Collaborator Author

(i don't see any changes to roman.x.y.z on the site, but maybe im just oblivious...)

@ryankeleti
Copy link
Owner

no, they aren't updated. the reason for this is that plastex has different attributes for the Node object, i.e. obj.ref and obj.id. The issue is that since some environments have more than one label (like equation labels), the ids don't always match up. I'm working in fixing this

@ryankeleti ryankeleti self-assigned this Jan 27, 2020
@ryankeleti
Copy link
Owner

part 3 is now done

@thosgood
Copy link
Collaborator Author

thosgood commented Jan 27, 2020

awesome! how much of a faff is it to do the same for the chapter/section numbering in the navigation breadcrumbs/TOC as well? (i'm guessing that this is the same as the numbering in the references too)

@ryankeleti
Copy link
Owner

fixed it for references

@ryankeleti
Copy link
Owner

fixed it for breadcrumbs/TOC

@thosgood
Copy link
Collaborator Author

one last idea for part 3. (sorry!)... (also gonna edit the issue to make it clear what you've already done)
the TOC (https://ega.fppf.site/browse) says Part 0, Part I, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web Anything related to the website
Projects
None yet
Development

No branches or pull requests

2 participants