Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement wrapper structs for row or column major ordered sorting and remove Ord/PartialOrd direct implementations on Position, RoomXY, RoomName #523

Open
shanemadden opened this issue Jun 28, 2024 · 0 comments
Open

Implement wrapper structs for row or column major ordered sorting and remove Ord/PartialOrd direct implementations on Position, RoomXY, RoomName #523

shanemadden opened this issue Jun 28, 2024 · 0 comments
Labels
C-enhancement Category: A PR with an enhancement or a proposed on in an issue.

Comments

@shanemadden
Copy link
Collaborator

shanemadden commented Jun 28, 2024 •
edited
Loading

See discussion in #521 and #226 - instead of having a presumed sort ordering priority for these types (which notably conflicts with the indexing on RoomTerrain/LocalRoomTerrain) we should remove the direct impls on these types and instead have wrappers which implementing the ordering traits.
@shanemadden shanemadden mentioned this issue Jun 28, 2024
Merged
@shanemadden shanemadden added the C-enhancement Category: A PR with an enhancement or a proposed on in an issue. label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: A PR with an enhancement or a proposed on in an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shanemadden