Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhelpful error types #230

Closed
drdo opened this issue Jul 20, 2024 · 2 comments
Closed

Unhelpful error types #230

drdo opened this issue Jul 20, 2024 · 2 comments
Labels
A-api Area: Related to API design of rustic_core A-errors Area: error handling needs improvement C-enhancement Category: New feature or request

Comments

@drdo
Copy link

drdo commented Jul 20, 2024

As an example, when opening a Repository if the host cannot be found we get only a ListingRepositoryConfigFileFailed with no indication as to why this happened.

It would be nice if this type included information about the upstream errors that caused this (in this case probably opendal::Error at least).
@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Jul 20, 2024
@simonsan simonsan added A-errors Area: error handling needs improvement C-enhancement Category: New feature or request A-api Area: Related to API design of rustic_core and removed S-triage Status: Waiting for a maintainer to triage this issue/PR labels Jul 20, 2024
@simonsan
Copy link
Contributor

I agree, the whole error handling situation is a bit cumbersome at this point and a rework is needed with the above-mentioned improvements. 👍🏽

@simonsan
Copy link
Contributor

We reworked and improved the RusticError API in https://github.com/rustic-rs/rustic_core/releases/tag/rustic_core-v0.6.0

In case there are still problems, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-api Area: Related to API design of rustic_core A-errors Area: error handling needs improvement C-enhancement Category: New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drdo @simonsan