Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't diff with a path begin with drive letter under windows #998

Closed
9-2-1 opened this issue Jan 9, 2024 · 3 comments · Fixed by #1000
Closed

Can't diff with a path begin with drive letter under windows #998

9-2-1 opened this issue Jan 9, 2024 · 3 comments · Fixed by #1000
Labels
A-cli Area: `rustic` command line interface A-commands Area: Related to commands in `rustic` A-ui-ux Area: Related to user interfaces and user experience C-bug Category: Something isn't working as expected O-windows Operating system: Windows

Comments

@9-2-1
Copy link

9-2-1 commented Jan 9, 2024

For example, rustic diff f0ca1025:D:\data D:\data will fail with error error: no suitable id found for D

Suggestion: treat single letter "id" as drive letter, or add an special "local" id to represent local path local:D:\data

@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Jan 9, 2024
@aawsome
Copy link
Member

aawsome commented Jan 10, 2024

Thanks @9-2-1 for reporting. This is obviously a syntax problem here.
I opt for adding a local: prefix - as we might want to add remote source in future where we also might want to use local: as local fs.

@aawsome aawsome added C-bug Category: Something isn't working as expected A-compatibility Area: Repo format is not (fully) compatible with restic A-cli Area: `rustic` command line interface O-windows Operating system: Windows A-commands Area: Related to commands in `rustic` A-ui-ux Area: Related to user interfaces and user experience and removed S-triage Status: Waiting for a maintainer to triage this issue/PR A-compatibility Area: Repo format is not (fully) compatible with restic labels Jan 10, 2024
@9-2-1
Copy link
Author

9-2-1 commented Jan 11, 2024

I realized that, under windows, backslash \ is used in local path, while rustic only treat a string including / as a path, so paths like D:\abc\, docs and folder\docs won't work.

@aawsome
Copy link
Member

aawsome commented Jan 11, 2024

With #1000, local:D:\abc\, local:docs and local:folder\docs should work.
It will be available in the next nightly builds, too (I guess tomorrow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: `rustic` command line interface A-commands Area: Related to commands in `rustic` A-ui-ux Area: Related to user interfaces and user experience C-bug Category: Something isn't working as expected O-windows Operating system: Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants