Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render TOML version of show-config #1093

Closed
AlphaJack opened this issue Mar 7, 2024 · 3 comments
Closed

Render TOML version of show-config #1093

AlphaJack opened this issue Mar 7, 2024 · 3 comments
Labels
A-commands Area: Related to commands in `rustic` C-enhancement Category: New feature or request

Comments

@AlphaJack
Copy link

Hi, would it be possible to get the output of show-config in JSON format? Right now the --json flag is not supported
@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Mar 7, 2024
@aawsome
Copy link
Member

aawsome commented Mar 7, 2024

Actually I think it would be better to output some TOML - as the file format is toml, too. And I think it would be better to rename as it is a bit ambiguous (there is the profle config we are talking here and the in-repo config which can be set by rustic config). Maybe something like show-profile? or profile show-config?

@aawsome aawsome mentioned this issue Mar 7, 2024
Merged
@simonsan
Copy link
Contributor

simonsan commented Mar 7, 2024

I agree with the toml choice, also because you can output it via >> to another file from that to copy a config. With the renaming, I would wait until we think about the cli refactor (if we want to go down this route)?

@aawsome aawsome added C-enhancement Category: New feature or request A-commands Area: Related to commands in `rustic` and removed S-triage Status: Waiting for a maintainer to triage this issue/PR labels Mar 15, 2024
@aawsome aawsome changed the title Render JSON version of show-config Render TOML version of show-config Mar 27, 2024
aawsome added a commit that referenced this issue Apr 10, 2024
@aawsome @simonsan
feat(commands)!: show-config now outputs toml (#1095)
88b21a8 
`show-config` now outputs toml.

see #1093

---------

Co-authored-by: simonsan <[email protected]>
@aawsome
Copy link
Member

aawsome commented Apr 18, 2024

Is implemented via #1095. I close this issue - the renaming of commands is another concern.

@aawsome aawsome closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-commands Area: Related to commands in `rustic` C-enhancement Category: New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonsan @AlphaJack @aawsome