-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve error handling #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be fine to return None
from guess_os_stack
when procfs
isn't available, but in principle it also doesn't change that for most intents and purposes systems configured that way are sorta broken for the purposes of *-linux-gnu
targets at least.
VirtualQuery is a faillible function that was treated as infaillible https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-virtualquery
@nagisa I reorganized guess_os_stack to have separate files per backend, addressed your comments, and added more error handling where it was missing on other platforms. |
Great, thank you very much @nagisa ! |
fixes #115
See sqlpage/SQLPage#814