You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The graphs page currently only shows compile benchmarks, it would be nice to add also runtime benchmarks to it.
It can be done in multiple ways, e.g. by adding a completely separate page, by adding a new tab, or just by introducing a new category within the same page (there is already a separate category for binary sizes at the bottom). I would prefer either the tab or the category.
The text was updated successfully, but these errors were encountered:
Basically, I plan to proceed with the design outlined in this reply, but before I begin, I’d like to confirm it with you to ensure we're aligned.
You said, "maybe with first just adding a single tab for compile-time benchmarks, and not modifying anything else."
I assume that I am a user, seeing only a single compile-time tab at the top of the graphs page without any additional functionality might feel a bit odd. Personally, I still lean towards implementing both the compile-time and runtime tabs at once. When switching to the runtime tab, we could simply display 'to be continued' for now.
An additional benefit of this approach is that the tab-switching functionality can be completed at the same time, avoiding the need to figure out how to implement tab switching later on.
This is just my personal opinion, and I will directly follow your decision.
I should have more time for reviews now, and the build system issue should be hopefully resolved now, so feel free to implement both the tab system and the runtime graphs in the same PR :)
The graphs page currently only shows compile benchmarks, it would be nice to add also runtime benchmarks to it.
It can be done in multiple ways, e.g. by adding a completely separate page, by adding a new tab, or just by introducing a new category within the same page (there is already a separate category for binary sizes at the bottom). I would prefer either the tab or the category.
The text was updated successfully, but these errors were encountered: