Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime benchmark historical charts to the graphs page #1817

Open
Kobzol opened this issue Feb 13, 2024 · 3 comments
Open

Add runtime benchmark historical charts to the graphs page #1817

Kobzol opened this issue Feb 13, 2024 · 3 comments
Labels
help wanted We are looking for volunteers to take on this issue

Comments

@Kobzol
Copy link
Contributor

Kobzol commented Feb 13, 2024

The graphs page currently only shows compile benchmarks, it would be nice to add also runtime benchmarks to it.

It can be done in multiple ways, e.g. by adding a completely separate page, by adding a new tab, or just by introducing a new category within the same page (there is already a separate category for binary sizes at the bottom). I would prefer either the tab or the category.

@Kobzol Kobzol added the help wanted We are looking for volunteers to take on this issue label Feb 13, 2024
@chengr4
Copy link
Contributor

chengr4 commented Mar 26, 2024

I will try to make this

TODO:

  • Tab component abstraction Tab component abstraction #1882
  • Add Tabs to graphs page UI
  • Collapse subset of the compile-time category
  • Add runtime benchmark graphs

@chengr4
Copy link
Contributor

chengr4 commented Dec 25, 2024

@Kobzol Merry Christmas!

Basically, I plan to proceed with the design outlined in this reply, but before I begin, I’d like to confirm it with you to ensure we're aligned.

You said, "maybe with first just adding a single tab for compile-time benchmarks, and not modifying anything else."

I assume that I am a user, seeing only a single compile-time tab at the top of the graphs page without any additional functionality might feel a bit odd. Personally, I still lean towards implementing both the compile-time and runtime tabs at once. When switching to the runtime tab, we could simply display 'to be continued' for now.

An additional benefit of this approach is that the tab-switching functionality can be completed at the same time, avoiding the need to figure out how to implement tab switching later on.

Image

This is just my personal opinion, and I will directly follow your decision.

@Kobzol
Copy link
Contributor Author

Kobzol commented Dec 26, 2024

I should have more time for reviews now, and the build system issue should be hopefully resolved now, so feel free to implement both the tab system and the runtime graphs in the same PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We are looking for volunteers to take on this issue
Projects
None yet
Development

No branches or pull requests

2 participants