Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable-only benchmarks don't run locally #1777

Closed
Nadrieril opened this issue Dec 19, 2023 · 4 comments · Fixed by #1780
Closed

Stable-only benchmarks don't run locally #1777

Nadrieril opened this issue Dec 19, 2023 · 4 comments · Fixed by #1780

Comments

@Nadrieril
Copy link
Member

Some benchmarks like encoding are category: stable instead of category: primary/secondary. When I run collector bench_local --include encoding,..., encoding is not run. Is there a way to make it run, short of locally changing its category?

@Nadrieril Nadrieril changed the title How to run stable-only benchmarks? Stable-only benchmarks don't run locally Dec 19, 2023
@Kobzol
Copy link
Contributor

Kobzol commented Dec 19, 2023

It's not currently possible because of this. We can probably just remove that line though.

Out of curiousity, what is your use-case for running a stable benchmark?

@Nadrieril
Copy link
Member Author

Removing this line would fix my problem :D Maybe --include primary,secondary could filter just these for anyone who needs that? I only ever run a selected set of benchmarks myself since I only touch match checking.

My use-case is testing whether we can remove an old hack that specifically regressed encoding (here).

@Kobzol
Copy link
Contributor

Kobzol commented Dec 19, 2023

@nnethercote Did you have any specific motivation for disabling stable benchmarks in bench_local?

@nnethercote
Copy link
Contributor

Because running the stable benchmarks locally is almost never what you want to do. More detail here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants