From 1aa55009117badd30a5f3f215ad3346b1cc5ba2f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Ber=C3=A1nek?= Date: Sat, 25 Nov 2023 19:28:31 +0100 Subject: [PATCH] Remove speedscope link from detailed query page It hasn't been working for a long time. --- site/frontend/src/pages/detailed-query.ts | 26 ++++------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/site/frontend/src/pages/detailed-query.ts b/site/frontend/src/pages/detailed-query.ts index 4a89c87b3..feb407461 100644 --- a/site/frontend/src/pages/detailed-query.ts +++ b/site/frontend/src/pages/detailed-query.ts @@ -71,14 +71,6 @@ function populate_data(data, state: Selector) { window.location.origin + processed_url(commit, bench, run, "crox"); return encodeURIComponent(crox_url); }; - let speedscope_link = (commit, bench, run) => { - let benchmark_name = `${bench} run ${run}`; - let crox_url = processed_crox_url(commit, bench, run); - let speedscope_url = `https://www.speedscope.app/#profileURL=${crox_url}&title=${encodeURIComponent( - benchmark_name - )}`; - return `speedscope.app`; - }; let firefox_profiler_link = (commit, bench, run) => { let crox_url = processed_crox_url(commit, bench, run); let ff_url = `https://profiler.firefox.com/from-url/${crox_url}/marker-chart/?v=5`; @@ -99,16 +91,11 @@ function populate_data(data, state: Selector) { state, "codegen-schedule" )} - (${speedscope_link( + (${firefox_profiler_link( state.base_commit, state.benchmark, state.scenario - )}, - ${firefox_profiler_link( - state.base_commit, - state.benchmark, - state.scenario - )}) + )}) results for ${state.base_commit.substring( 0, 10 @@ -120,16 +107,11 @@ function populate_data(data, state: Selector) { ${processed_link(state.commit, state, "flamegraph")}, ${processed_link(state.commit, state, "crox")}, ${processed_link(state.commit, state, "codegen-schedule")} - (${speedscope_link( + (${firefox_profiler_link( state.commit, state.benchmark, state.scenario - )}, - ${firefox_profiler_link( - state.commit, - state.benchmark, - state.scenario - )}) + )}) results for ${state.commit.substring(0, 10)} (new commit)`; // TODO: use the Cachegrind Vue components once this page is refactored to Vue let profile = (b) =>